[
https://issues.apache.org/jira/browse/PHOENIX-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285048#comment-17285048
]
ASF GitHub Bot commented on PHOENIX-5259:
-----------------------------------------
stoty commented on pull request #589:
URL: https://github.com/apache/phoenix/pull/589#issuecomment-779596667
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 30s | master passed |
| +0 | hbaserecompile | 22m 38s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | checkstyle | 1m 42s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
| +0 :ok: | spotbugs | 3m 3s | phoenix-core in master has 959 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 10s | the patch passed |
| +0 | hbaserecompile | 18m 27s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 46s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 19s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 108m 47s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 45s | The patch generated 1 ASF License
warnings. |
| | | 165m 26s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.DeleteIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-589/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/589 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 29b6fe693cd4 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 6ed3caf |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-589/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-589/1/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-589/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 11060 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-589/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Phoenix Salted Table Secondary Indexes Come Salted
> --------------------------------------------------
>
> Key: PHOENIX-5259
> URL: https://issues.apache.org/jira/browse/PHOENIX-5259
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.13.1
> Reporter: Daniel Wong
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This issue was discussed internally a while ago based on Phoenix 4.13 on
> HBase 1.3. I found if a base table was generated salted a secondary index
> built on top of that table would also be salted. There is no reason for this
> to occur based on my understanding and a discussion with [~tdsilva],
> [~lhofhansl], and [~kozdemir]. Writing this up now so it gets evaluated at
> some point in the future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
