[
https://issues.apache.org/jira/browse/PHOENIX-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288258#comment-17288258
]
ASF GitHub Bot commented on PHOENIX-6388:
-----------------------------------------
virajjasani commented on a change in pull request #1146:
URL: https://github.com/apache/phoenix/pull/1146#discussion_r580069347
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -586,17 +595,28 @@ private boolean verifyRowAndRepairIfNecessary(List<Cell>
cellList) throws IOExce
long ts = cellList.get(0).getTimestamp();
cellList.clear();
+ long repairTime;
try {
repairIndexRows(rowKey, ts, cellList);
+ repairTime = EnvironmentEdgeManager.currentTimeMillis() -
repairStart;
metricsSource.incrementIndexRepairs(indexName);
metricsSource.updateUnverifiedIndexRowAge(indexName,
EnvironmentEdgeManager.currentTimeMillis() - ts);
metricsSource.updateIndexRepairTime(indexName,
EnvironmentEdgeManager.currentTimeMillis() -
repairStart);
+ if (shouldLog()) {
+ LOG.info(String.format("Index row repair on region %s
took %d ms.",
+ env.getRegionInfo().getRegionNameAsString(),
repairTime));
+ }
Review comment:
> nor is logging the same event twice at different logging levels.
Yeah got your point, sure I think it's fine, we don't need TRACE level
logging, anyways we have some useful metrics available too e.g
`unverifiedIndexRowAge`, `indexRepairTime` etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add sampled logging for read repairs
> ------------------------------------
>
> Key: PHOENIX-6388
> URL: https://issues.apache.org/jira/browse/PHOENIX-6388
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Minor
> Fix For: 5.1.1, 4.16.1, 4.17.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
