[ https://issues.apache.org/jira/browse/PHOENIX-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290628#comment-17290628 ]
Hadoop QA commented on PHOENIX-5991: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 14s{color} | {color:red} PHOENIX-5991 does not apply to 4.x. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | PHOENIX-5991 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13007229/PHOENIX-5991.4.x.001.patch | | Console output | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/380/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > IndexRegionObserver should not overwrite mutation timestamps set by clients > --------------------------------------------------------------------------- > > Key: PHOENIX-5991 > URL: https://issues.apache.org/jira/browse/PHOENIX-5991 > Project: Phoenix > Issue Type: Improvement > Reporter: Kadir OZDEMIR > Assignee: Kadir OZDEMIR > Priority: Major > Attachments: PHOENIX-5991.4.x.001.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Phoenix client can set mutation timestamps for connections with scn. For > example, it sets the timestamp for delete mutations. IndexRegionObserver does > not check if the timestamp is set for mutations and overwrites them with its > current time. While Phoenix does not support setting arbitrary timestamps on > the client side for all operations, setting a timestamp for delete mutations > is harmless even for tables with indexes. Instead of blindly overwriting > mutations timestamps, IndexRegionObserver can leave the determination of > which timestamp values are allowed for which operations and sets the > timestamp for mutations only when they are not set by Phoenix client. -- This message was sent by Atlassian Jira (v8.3.4#803005)