[
https://issues.apache.org/jira/browse/PHOENIX-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300202#comment-17300202
]
ASF GitHub Bot commented on PHOENIX-6385:
-----------------------------------------
stoty commented on pull request #1167:
URL: https://github.com/apache/phoenix/pull/1167#issuecomment-797393489
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 16m 35s | master passed |
| +0 | hbaserecompile | 23m 28s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 8s | master passed |
| +1 :green_heart: | checkstyle | 0m 46s | master passed |
| +1 :green_heart: | javadoc | 0m 58s | master passed |
| +0 :ok: | spotbugs | 3m 30s | phoenix-core in master has 959 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 53s | the patch passed |
| +0 | hbaserecompile | 20m 17s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 9s | the patch passed |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| -1 :x: | checkstyle | 0m 45s | phoenix-core: The patch generated 5
new + 685 unchanged - 5 fixed = 690 total (was 690) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 53s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 18s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 113m 53s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 18s | The patch does not generate
ASF License warnings. |
| | | 173m 40s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1167/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1167 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 5f9a4e6569c0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 8e06ada |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1167/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1167/1/testReport/
|
| Max. process+thread count | 14837 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1167/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Not to use Scan#setSmall for HBase 2.x versions
> -----------------------------------------------
>
> Key: PHOENIX-6385
> URL: https://issues.apache.org/jira/browse/PHOENIX-6385
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Anoop Sam John
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.1, 5.2.0
>
>
> {code:java}
> /**
> * Set whether this scan is a small scan
> * <p>
> * Small scan should use pread and big scan can use seek + read seek + read
> is fast but can cause
> * two problem (1) resource contention (2) cause too much network io
> [89-fb] Using pread for
> * non-compaction read request
> https://issues.apache.org/jira/browse/HBASE-7266 On the other hand,
> * if setting it true, we would do openScanner,next,closeScanner in one RPC
> call. It means the
> * better performance for small scan. [HBASE-9488]. Generally, if the scan
> range is within one
> * data block(64KB), it could be considered as a small scan.
> * @param small
> * @deprecated since 2.0.0 and will be removed in 3.0.0. Use {@link
> #setLimit(int)} and
> * {@link #setReadType(ReadType)} instead. And for the one rpc
> optimization, now we will also
> * fetch data when openScanner, and if the number of rows reaches the
> limit then we will close
> * the scanner automatically which means we will fall back to one rpc.
> * @see #setLimit(int)
> * @see #setReadType(ReadType)
> * @see <a
> href="https://issues.apache.org/jira/browse/HBASE-17045";>HBASE-17045</a>
> */
> @Deprecated
> public Scan setSmall(boolean small)
> {code}
> In 1.x there is seperate ClientSmallScanner impl doing single RPC for scan.
> In 2.x by default it handles single RPC if there are less number of rows.
> We might have to setLimit.
> Also in 2.x setSmall() API sets the readType to be PRead. But this is good
> for small reads like only one hfile blocks get read. But what I noticed in
> phoenix is that even count(*) query result in setting Scan as small scan and
> end up using PRead (This will result in full scan).
> So we should not be setting the ReadType at all. Instead rely on HBase to
> intelligently switch scan type (start with PRead and if it scans more data
> switch to stream read)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
