stoty commented on pull request #1170: URL: https://github.com/apache/phoenix/pull/1170#issuecomment-803826804
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x-PHOENIX-6247 Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 58s | 4.x-PHOENIX-6247 passed | | +1 :green_heart: | compile | 1m 5s | 4.x-PHOENIX-6247 passed | | +1 :green_heart: | checkstyle | 4m 27s | 4.x-PHOENIX-6247 passed | | +1 :green_heart: | javadoc | 0m 48s | 4.x-PHOENIX-6247 passed | | +0 :ok: | spotbugs | 3m 18s | phoenix-core in 4.x-PHOENIX-6247 has 944 extant spotbugs warnings. | | -0 :warning: | patch | 3m 25s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 51s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | cc | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | -1 :x: | checkstyle | 4m 32s | phoenix-core: The patch generated 282 new + 14838 unchanged - 158 fixed = 15120 total (was 14996) | | +1 :green_heart: | prototool | 0m 1s | There were no new prototool issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | javadoc | 0m 47s | phoenix-core generated 1 new + 92 unchanged - 0 fixed = 93 total (was 92) | | -1 :x: | spotbugs | 3m 29s | phoenix-core generated 2 new + 944 unchanged - 0 fixed = 946 total (was 944) | ||| _ Other Tests _ | | -1 :x: | unit | 235m 19s | phoenix-core in the patch failed. | | -1 :x: | asflicense | 0m 38s | The patch generated 1 ASF License warnings. | | | | 281m 15s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326] | | | Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes() At ConnectionQueryServicesImpl.java:[line 2249] | | Failed junit tests | phoenix.tx.FlappingTransactionIT | | | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.ParameterizedIndexUpgradeToolIT | | | phoenix.end2end.index.GlobalImmutableTxIndexIT | | | phoenix.end2end.SystemCatalogRollbackEnabledIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT | | | phoenix.end2end.LogicalTableNameIT | | | phoenix.end2end.index.LocalImmutableTxIndexIT | | | phoenix.tx.TransactionIT | | | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.BackwardCompatibilityIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1170 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool | | uname | Linux 22b707d4b7b9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x-PHOENIX-6247 / e6d7d0b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 4900 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
