[
https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308381#comment-17308381
]
ASF GitHub Bot commented on PHOENIX-6247:
-----------------------------------------
stoty commented on pull request #1170:
URL: https://github.com/apache/phoenix/pull/1170#issuecomment-806362874
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x-PHOENIX-6247 Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 57s | 4.x-PHOENIX-6247 passed |
| +1 :green_heart: | compile | 1m 8s | 4.x-PHOENIX-6247 passed |
| +1 :green_heart: | checkstyle | 4m 6s | 4.x-PHOENIX-6247 passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x-PHOENIX-6247 passed |
| +0 :ok: | spotbugs | 3m 16s | phoenix-core in 4.x-PHOENIX-6247 has
941 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 45s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | cc | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| -1 :x: | checkstyle | 4m 14s | phoenix-core: The patch generated 232
new + 13806 unchanged - 99 fixed = 14038 total (was 13905) |
| +1 :green_heart: | prototool | 0m 1s | There were no new prototool
issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| -1 :x: | spotbugs | 3m 30s | phoenix-core generated 5 new + 941
unchanged - 0 fixed = 946 total (was 941) |
||| _ Other Tests _ |
| -1 :x: | unit | 192m 18s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate
ASF License warnings. |
| | | 237m 36s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Found reliance on default encoding in
org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController,
MetaDataProtos$CreateTableRequest, RpcCallback):in
org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController,
MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes() At
MetaDataEndpointImpl.java:[line 1929] |
| | Found reliance on default encoding in
org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner,
long, long, int):in
org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner,
long, long, int): String.getBytes() At MetaDataEndpointImpl.java:[line 1237] |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a
mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line
326] |
| | Found reliance on default encoding in
org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable,
long, boolean):in
org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable,
long, boolean): String.getBytes() At ConnectionQueryServicesImpl.java:[line
2250] |
| | Call to String.equals(org.apache.phoenix.schema.PName) in
org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties,
MetaDataClient$MetaPropertiesEvaluated, PTable, String, String) At
MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String,
String) At MetaDataClient.java:[line 5419] |
| Failed junit tests | phoenix.end2end.index.txn.RollbackIT |
| | phoenix.end2end.UpsertSelectIT |
| | phoenix.end2end.LogicalTableNameIT |
| | phoenix.tx.TransactionIT |
| | phoenix.end2end.UpsertWithSCNIT |
| | phoenix.end2end.ViewUtilIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1170 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool |
| uname | Linux 7122dd8b0d65 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9
06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x-PHOENIX-6247 / 410f738 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/testReport/
|
| Max. process+thread count | 4945 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from
> logical name (Phoenix name)
> --------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6247
> URL: https://issues.apache.org/jira/browse/PHOENIX-6247
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
>
> Currently, the tables in Phoenix have the same name as the underlying Hbase
> table. Separating logical and physical table name, ie. Having a Phoenix table
> point to an Hbase table with a different name have some advantages.
> An example is this: Let's say we want to have a different storage/encoding
> scheme for an index. We can build the new index while the clients use the old
> index and once the index is rebuilt, we can momentarily start pointing to the
> new index table without much downtime or performance implications. For the
> client, they are using the same index with the same name, but the physical
> table is different. Today, in order to change the index like this, we have to
> drop it and re-create which is a downtime for the index and the data table
> full scans are used for queries impacting performance while the index
> creation goes on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
