[
https://issues.apache.org/jira/browse/PHOENIX-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308952#comment-17308952
]
ASF GitHub Bot commented on PHOENIX-6357:
-----------------------------------------
stoty commented on pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#issuecomment-807393087
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 54s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 49s | master passed |
| +0 | hbaserecompile | 24m 37s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 6s | master passed |
| +1 :green_heart: | checkstyle | 1m 39s | master passed |
| +1 :green_heart: | javadoc | 1m 32s | master passed |
| +0 :ok: | spotbugs | 3m 19s | phoenix-core in master has 956 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 49s | phoenix-pherf in master has 42 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 43s | phoenix-tools in master has 3 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 9m 57s | the patch passed |
| +0 | hbaserecompile | 16m 57s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 6s | the patch passed |
| +1 :green_heart: | javac | 2m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 12s | phoenix-core: The patch generated 25
new + 2540 unchanged - 39 fixed = 2565 total (was 2579) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 1m 28s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 24s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 25s | phoenix-core in the patch failed. |
| -1 :x: | unit | 10m 40s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | unit | 3m 5s | phoenix-tools in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 30s | The patch does not generate
ASF License warnings. |
| | | 207m 9s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1184 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 21341f6bf058 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f9532bd |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/testReport/
|
| Max. process+thread count | 10758 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change all command line tools to use the fixed commons-cli constructor
> ----------------------------------------------------------------------
>
> Key: PHOENIX-6357
> URL: https://issues.apache.org/jira/browse/PHOENIX-6357
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Creating DefaultParser with the new DefaultParser(true, false) or
> DefaultParser(false, false)
> constructors will not mangle the double quotes for our tools.
> Change all tools to use that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
