tkhurana commented on a change in pull request #1183:
URL: https://github.com/apache/phoenix/pull/1183#discussion_r602577275
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##########
@@ -586,10 +638,11 @@ public boolean hasNext() {
// the tables in the mutations map
if (!sendAll) {
TableRef key = new TableRef(index);
- MultiRowMutationState multiRowMutationState =
mutations.remove(key);
+ List<MultiRowMutationState> multiRowMutationState =
mutationsMap.remove(key);
if (multiRowMutationState != null) {
final List<Mutation> deleteMutations =
Lists.newArrayList();
- generateMutations(key, mutationTimestamp,
serverTimestamp, multiRowMutationState, deleteMutations, null);
+ // for index table there will only be 1 mutation
batch in the list
Review comment:
@gjacoby126 For indexes, the only time we see an entry in the map is in
case of deletes and that too for immutable indexes. So I don't expect a
conflicting update unless someone explicitly does a regular upsert and
conditional upsert directly on index table which is theoretically possible but
highly unlikely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
