[ 
https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309821#comment-17309821
 ] 

ASF GitHub Bot commented on PHOENIX-6429:
-----------------------------------------

stoty commented on pull request #1185:
URL: https://github.com/apache/phoenix/pull/1185#issuecomment-808599154


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 32s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
5 new or modified test files.  |
   ||| _ 4.x Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  14m 22s |  4.x passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   0m 24s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   0m 18s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   0m 57s |  phoenix-pherf in 4.x has 50 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 46s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 37s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 37s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 26s |  phoenix-pherf: The patch generated 96 
new + 507 unchanged - 31 fixed = 603 total (was 538)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch 8 line(s) with tabs.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   0m 15s |  the patch passed  |
   | -1 :x: |  spotbugs  |   1m 17s |  phoenix-pherf generated 2 new + 50 
unchanged - 0 fixed = 52 total (was 50)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   9m 35s |  phoenix-pherf in the patch passed. 
 |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  36m 11s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-pherf |
   |  |  Switch statement found in 
org.apache.phoenix.pherf.rules.RulesApplier.getRuleBasedDataGeneratorForColumn(Column)
 where default case is missing  At RulesApplier.java:where default case is 
missing  At RulesApplier.java:[lines 555-573] |
   |  |  A prepared statement is generated from a nonconstant String in 
org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)
  At PreScenarioOperationSupplier.java:from a nonconstant String in 
org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)
  At PreScenarioOperationSupplier.java:[line 69] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1185 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile xml |
   | uname | Linux d97d90b96f85 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 3535708 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/whitespace-tabs.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/testReport/
 |
   | Max. process+thread count | 1842 (vs. ulimit of 30000) |
   | modules | C: phoenix-pherf U: phoenix-pherf |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Add support for global connections and sequential data generators
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-6429
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6429
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Jacob Isaac
>            Priority: Major
>
> We may at times want to upsert or query using global connections. 
> Also add additional sequential data generators in addition to INTEGER and 
> VARCHAR data types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to