[
https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316851#comment-17316851
]
ASF GitHub Bot commented on PHOENIX-6247:
-----------------------------------------
stoty commented on pull request #1192:
URL: https://github.com/apache/phoenix/pull/1192#issuecomment-815430903
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x-PHOENIX-6247 Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 51s | 4.x-PHOENIX-6247 passed |
| +1 :green_heart: | compile | 1m 5s | 4.x-PHOENIX-6247 passed |
| +1 :green_heart: | checkstyle | 1m 43s | 4.x-PHOENIX-6247 passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x-PHOENIX-6247 passed |
| +0 :ok: | spotbugs | 3m 15s | phoenix-core in 4.x-PHOENIX-6247 has
946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 51s | the patch passed |
| +1 :green_heart: | compile | 1m 5s | the patch passed |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -1 :x: | checkstyle | 1m 42s | phoenix-core: The patch generated 20
new + 4691 unchanged - 3 fixed = 4711 total (was 4694) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 31s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 196m 2s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate
ASF License warnings. |
| | | 238m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1192/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1192 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 8003fb7ca960 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x-PHOENIX-6247 / 2279410 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1192/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1192/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1192/1/testReport/
|
| Max. process+thread count | 5105 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1192/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from
> logical name (Phoenix name)
> --------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6247
> URL: https://issues.apache.org/jira/browse/PHOENIX-6247
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
>
> Currently, the tables in Phoenix have the same name as the underlying Hbase
> table. Separating logical and physical table name, ie. Having a Phoenix table
> point to an Hbase table with a different name have some advantages.
> An example is this: Let's say we want to have a different storage/encoding
> scheme for an index. We can build the new index while the clients use the old
> index and once the index is rebuilt, we can momentarily start pointing to the
> new index table without much downtime or performance implications. For the
> client, they are using the same index with the same name, but the physical
> table is different. Today, in order to change the index like this, we have to
> drop it and re-create which is a downtime for the index and the data table
> full scans are used for queries impacting performance while the index
> creation goes on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
