[ 
https://issues.apache.org/jira/browse/PHOENIX-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334852#comment-17334852
 ] 

ASF GitHub Bot commented on PHOENIX-6351:
-----------------------------------------

stoty commented on pull request #1214:
URL: https://github.com/apache/phoenix/pull/1214#issuecomment-828592862


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   4m 21s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  15m 32s |  master passed  |
   | +0 |  hbaserecompile  |  22m 17s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m  6s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 50s |  master passed  |
   | +0 :ok: |  spotbugs  |   3m  7s |  phoenix-core in master has 960 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   8m  4s |  the patch passed  |
   | +0 |  hbaserecompile  |  17m 26s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  1s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  phoenix-core: The patch 
generated 0 new + 69 unchanged - 3 fixed = 69 total (was 72)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 50s |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   3m 15s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 117m 14s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 173m 10s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | phoenix.end2end.PermissionsCacheIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1214 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs 
hbaserebuild hbaseanti checkstyle compile |
   | uname | Linux 3f60aedf516b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / e9de744 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/testReport/
 |
   | Max. process+thread count | 15207 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> PhoenixMRJobUtil getActiveResourceManagerAddress logic fails on 
> pseudodistributed cluster
> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6351
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6351
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>            Reporter: Istvan Toth
>            Priority: Minor
>
> In 
> org.apache.phoenix.util.PhoenixMRJobUtil.getActiveResourceManagerAddress(Configuration,
>  String)
> We first check if YarnConfiguration.DEFAULT_RM_WEBAPP_ADDRESS is changed from 
> the default, and if it isn't, we try to get the HA RM from ZK.
> This fails with the default config on a pseudo-distributed cluster.
> We should probably try to get the HA RM first, and fall back to 
> YarnConfiguration.RM_WEBAPP_ADDRESS if that one is not available. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to