joshelser commented on a change in pull request #1210:
URL: https://github.com/apache/phoenix/pull/1210#discussion_r623190835
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java
##########
@@ -47,12 +48,14 @@ private QueryLogger(PhoenixConnection connection) {
this.queryId = UUID.randomUUID().toString();
this.queryDisruptor =
connection.getQueryServices().getQueryDisruptor();
logLevel = connection.getLogLevel();
+ auditLogLevel = connection.getAuditLogLevel();
Review comment:
> We can have both enabled and if we want to have logging for select
queries and for DML + DDL queries, we should.
Great! That sounds like the correct approach.
> In the latest change I separated AuditQueryLogger and LogSamplingRate has
no effect on it, I think If AUDIT_LOG_LEVEL is enabled we should log every
query.
Ok, I think that is fine. Let's make sure we circle back around an update
Phoenix documentation for this new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
