dbwong commented on pull request #1210: URL: https://github.com/apache/phoenix/pull/1210#issuecomment-829700859
> As Istvan points out, there's a big range out what users _want_ when it comes to auditing. I don't see what is in place right now as being burdensome (you have to know it's there and turn it on by default, now). That's not to say we have to leave it this way (I think automatically logging DDLs would be excellent!), but let's focus on what we want this usability to be. Wdyt, Daniel? I'm not opposed to the short term implementation, i'm just trying to make the end user opt in more generic so we won't have a migration to do in the future, or alternatively have multiple ways to configure query logging. Do I use audit logging/query logging or whatever improvements we build in the future? Which was why I was trying to push for a generalized solution where we specify a logging class, for example phoenix.log.queryLogger=org.apache.phoenix.log.auditLogger. Otherwise we may end up having a giant grid of options like you mentioned. I'm not strongly opposed but note that future improvements may want to completely removing these options, but we will feel obligated to keep them for compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
