[
https://issues.apache.org/jira/browse/PHOENIX-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338699#comment-17338699
]
ASF GitHub Bot commented on PHOENIX-6457:
-----------------------------------------
stoty commented on pull request #1216:
URL: https://github.com/apache/phoenix/pull/1216#issuecomment-831613663
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 51s | 4.x passed |
| +1 :green_heart: | compile | 1m 5s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 7s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 49s | 4.x passed |
| +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | cc | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 3m 15s | phoenix-core: The patch generated 75
new + 10260 unchanged - 25 fixed = 10335 total (was 10285) |
| +1 :green_heart: | prototool | 0m 1s | There were no new prototool
issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 33s | phoenix-core generated 1 new + 944
unchanged - 1 fixed = 945 total (was 945) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 196m 41s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate
ASF License warnings. |
| | | 237m 33s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SCHEMA_VERSION_BYTES
is a mutable array At MetaDataEndpointImpl.java: At
MetaDataEndpointImpl.java:[line 344] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1216/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1216 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool |
| uname | Linux f793742f68bc 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9
06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 21bfbad |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1216/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1216/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1216/2/testReport/
|
| Max. process+thread count | 5093 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1216/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optionally store schema version string in SYSTEM.CATALOG
> --------------------------------------------------------
>
> Key: PHOENIX-6457
> URL: https://issues.apache.org/jira/browse/PHOENIX-6457
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
>
> In many environments, schema changes to Phoenix tables are applied in batches
> associated with a version of an application. (For example, v1.0 of an app may
> start with one set of CREATE statements, v1.1 then adds some ALTER
> statements, etc.)
> It can be useful to be able to look up the latest app version in which a
> table or view was changed; this could potentially be added as a feature of
> the Schema Tool.
> This change would add an optional property to CREATE and ALTER statements,
> SCHEMA_VERSION, which would take a user-supplied string.
> This is also a pre-req for PHOENIX-6227, because we would want to pass the
> schema version string, if any, to an external schema repository in
> environments where we're integrating with one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
