xcangCRM commented on a change in pull request #1219:
URL: https://github.com/apache/phoenix/pull/1219#discussion_r625448015
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilterIT.java
##########
@@ -281,4 +347,68 @@ private int getAndAssertTenantCountInEdit(WAL.Entry entry)
{
}
return entry;
}
+
+ public WAL.Entry getEntry(TableName tableName, Scan scan, boolean
addIndexedKeyValueCell)
Review comment:
Does this have to be public?
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##########
@@ -103,18 +104,20 @@ private boolean isTenantRowCellSystemChildLink(final Cell
cell) {
if (!isTenantRowCell) {
boolean isChildLink = CellUtil.matchingQualifier(
cell, PhoenixDatabaseMetaData.LINK_TYPE_BYTES);
- if (isChildLink) {
- if (CellUtil.matchingValue(cell, CHILD_TABLE_BYTES)) {
+ // Check if cell is of type LINK_TYPE with value 4 or DeleteFamily
+ if ((isChildLink && CellUtil.matchingValue(cell, CHILD_TABLE_BYTES)) ||
+ CellUtil.isDeleteFamily(cell) ) {
Review comment:
this logic means you will replicate whenever it's a DeleteFamily cell,
regardless of childlink or not. Is this the intention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
