[
https://issues.apache.org/jira/browse/PHOENIX-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338713#comment-17338713
]
ASF GitHub Bot commented on PHOENIX-6454:
-----------------------------------------
stoty commented on pull request #1217:
URL: https://github.com/apache/phoenix/pull/1217#issuecomment-831640423
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 8s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 40s | 4.x passed |
| +1 :green_heart: | compile | 1m 38s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 49s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 4s | 4.x passed |
| +0 :ok: | spotbugs | 3m 18s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 49s | phoenix-tools in 4.x has 3 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| -1 :x: | checkstyle | 0m 31s | phoenix-core: The patch generated 32
new + 212 unchanged - 3 fixed = 244 total (was 215) |
| -1 :x: | checkstyle | 0m 17s | phoenix-tools: The patch generated 135
new + 251 unchanged - 12 fixed = 386 total (was 263) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 1m 0s | the patch passed |
| -1 :x: | spotbugs | 0m 59s | phoenix-tools generated 5 new + 0
unchanged - 3 fixed = 5 total (was 3) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 137m 18s | phoenix-core in the patch passed.
|
| -1 :x: | unit | 3m 30s | phoenix-tools in the patch failed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate
ASF License warnings. |
| | | 183m 6s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-tools |
| | Found reliance on default encoding in
org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in
org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):
new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 237] |
| |
org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String)
may fail to close stream At SchemaSynthesisProcessor.java:stream At
SchemaSynthesisProcessor.java:[line 237] |
| | org.apache.phoenix.schema.SchemaTool.conf should be package protected
In SchemaTool.java: In SchemaTool.java |
| | Possible null pointer dereference of cmdLine in
org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) on exception path
Dereferenced at SchemaTool.java:cmdLine in
org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) on exception path
Dereferenced at SchemaTool.java:[line 113] |
| | Write to static field org.apache.phoenix.schema.SchemaTool.conf from
instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At
SchemaTool.java:from instance method
org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line
74] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1217 |
| JIRA Issue | PHOENIX-6454 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 0058fa561ffe 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 21bfbad |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/testReport/
|
| Max. process+thread count | 6127 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-tools U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1217/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add feature to SchemaTool to get the DDL in specification mode
> --------------------------------------------------------------
>
> Key: PHOENIX-6454
> URL: https://issues.apache.org/jira/browse/PHOENIX-6454
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
>
> Currently, SchemExtractionTool uses PTable representation to get the
> effective DDL on the cluster.
> Rename SchemaExtractionTool to SchemaTool, add a feature that accepts create
> DDL and alter DDL to give effective DDL without using PTable implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
