stoty commented on pull request #1226:
URL: https://github.com/apache/phoenix/pull/1226#issuecomment-833990093


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 10s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
25 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  17m  4s |  master passed  |
   | +0 |  hbaserecompile  |  24m 33s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   0m 32s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 31s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  master passed  |
   | +0 :ok: |  spotbugs  |   0m 55s |  phoenix-pherf in master has 51 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   9m 58s |  the patch passed  |
   | +0 |  hbaserecompile  |  18m  0s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   0m 34s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 34s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 36s |  phoenix-pherf: The patch generated 533 
new + 757 unchanged - 285 fixed = 1290 total (was 1042)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m 10s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m 19s |  phoenix-pherf generated 25 new + 33 
unchanged - 24 fixed = 58 total (was 57)  |
   | -1 :x: |  spotbugs  |   1m  6s |  phoenix-pherf generated 12 new + 42 
unchanged - 9 fixed = 54 total (was 51)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   9m 44s |  phoenix-pherf in the patch passed. 
 |
   | +1 :green_heart: |  asflicense  |   0m 13s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  59m  4s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-pherf |
   |  |  Possible null pointer dereference in 
org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent)
 due to return value of called method  Dereferenced at 
RendezvousingWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent)
 due to return value of called method  Dereferenced at 
RendezvousingWorkHandler.java:[line 76] |
   |  |  Return value of 
org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil()
 ignored, but method has no side effect  At RendezvousingWorkHandler.java:but 
method has no side effect  At RendezvousingWorkHandler.java:[line 83] |
   |  |  Possible null pointer dereference in 
org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent)
 due to return value of called method  Dereferenced at 
TenantOperationWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent)
 due to return value of called method  Dereferenced at 
TenantOperationWorkHandler.java:[line 65] |
   |  |  Return value of 
org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil()
 ignored, but method has no side effect  At TenantOperationWorkHandler.java:but 
method has no side effect  At TenantOperationWorkHandler.java:[line 67] |
   |  |  input must be non-null but is marked as nullable  At 
IdleTimeOperationSupplier.java:is marked as nullable  At 
IdleTimeOperationSupplier.java:[lines 51-74] |
   |  |  input must be non-null but is marked as nullable  At 
PreScenarioOperationSupplier.java:is marked as nullable  At 
PreScenarioOperationSupplier.java:[lines 51-85] |
   |  |  A prepared statement is generated from a nonconstant String in 
org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)
  At PreScenarioOperationSupplier.java:from a nonconstant String in 
org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)
  At PreScenarioOperationSupplier.java:[line 74] |
   |  |  input must be non-null but is marked as nullable  At 
QueryOperationSupplier.java:is marked as nullable  At 
QueryOperationSupplier.java:[lines 54-94] |
   |  |  Impossible cast from RuntimeException to java.sql.SQLException in 
org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView,
 TenantOperationInfo)  At TenantOperationFactory.java:java.sql.SQLException in 
org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView,
 TenantOperationInfo)  At TenantOperationFactory.java:[line 354] |
   |  |  input must be non-null but is marked as nullable  At 
UpsertOperationSupplier.java:is marked as nullable  At 
UpsertOperationSupplier.java:[lines 58-161] |
   |  |  
org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo)
 may fail to clean up java.sql.Statement  Obligation to clean up resource 
created at UpsertOperationSupplier.java:up java.sql.Statement  Obligation to 
clean up resource created at UpsertOperationSupplier.java:[line 107] is not 
discharged |
   |  |  input must be non-null but is marked as nullable  At 
UserDefinedOperationSupplier.java:is marked as nullable  At 
UserDefinedOperationSupplier.java:[lines 43-47] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1226 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile 
spotbugs hbaserebuild hbaseanti checkstyle |
   | uname | Linux dd475f21660b 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 
06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 5265164 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/testReport/
 |
   | Max. process+thread count | 2332 (vs. ulimit of 30000) |
   | modules | C: phoenix-pherf U: phoenix-pherf |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to