stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-837399896


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  8s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
3 new or modified test files.  |
   ||| _ 4.x Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  15m 14s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m  5s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   2m  7s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   0m 48s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   3m 17s |  phoenix-core in 4.x has 945 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 47s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  4s |  the patch passed  |
   | -1 :x: |  checkstyle  |   2m 18s |  phoenix-core: The patch generated 709 
new + 6124 unchanged - 86 fixed = 6833 total (was 6210)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 46s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m 31s |  phoenix-core generated 5 new + 945 
unchanged - 0 fixed = 950 total (was 945)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 204m 55s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 41s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 246m 43s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  Load of known null value in 
org.apache.phoenix.monitoring.TableMetricsManager.getInstance()  At 
TableMetricsManager.java:in 
org.apache.phoenix.monitoring.TableMetricsManager.getInstance()  At 
TableMetricsManager.java:[line 88] |
   |  |  Write to static field 
org.apache.phoenix.monitoring.TableMetricsManager.options from instance method 
new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:from instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:[line 57] |
   |  |  Write to static field 
org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from 
instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:from instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:[line 69] |
   |  |  Write to static field 
org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled 
from instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:from instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:[line 58] |
   |  |  Write to static field 
org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping 
from instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:from instance method new 
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions)  At 
TableMetricsManager.java:[line 61] |
   | Failed junit tests | phoenix.end2end.AuditLoggingIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile |
   | uname | Linux 7ce4bc6e5401 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 
18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 6ac64c4 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/testReport/
 |
   | Max. process+thread count | 4799 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to