[
https://issues.apache.org/jira/browse/PHOENIX-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343440#comment-17343440
]
ASF GitHub Bot commented on PHOENIX-6462:
-----------------------------------------
gokceni commented on a change in pull request #1228:
URL: https://github.com/apache/phoenix/pull/1228#discussion_r631299501
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -408,7 +413,7 @@ public void close() throws IOException {
try {
if (verificationResultRepository != null) {
verificationResultRepository.logToIndexToolResultTable(verificationResult,
- verifyType,
region.getRegionInfo().getRegionName(), skipped);
+ verifyType,
region.getRegionInfo().getRegionName(), skipped, shouldRetry);
Review comment:
Wouln't it be too chatty? I added logging for the true case already. I
think it should be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Index build mapper that failed should not be logging into the
> PHOENIX_INDEX_TOOL_RESULT table
> ---------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6462
> URL: https://issues.apache.org/jira/browse/PHOENIX-6462
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gokcen Iskender
> Priority: Major
>
> Today, if a mapper fails it still logs the region into the
> PHOENIX_INDEX_TOOL_RESULT table. This causes into mistakenly thinking that
> the mapper succeeded. Incremental rebuilds will be mislead.
>
> [~swaroopa] [~tkhurana]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
