[
https://issues.apache.org/jira/browse/PHOENIX-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347978#comment-17347978
]
ASF GitHub Bot commented on PHOENIX-5838:
-----------------------------------------
stoty commented on pull request #1231:
URL: https://github.com/apache/phoenix/pull/1231#issuecomment-844565371
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
5 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 28s | 4.x passed |
| +1 :green_heart: | compile | 1m 38s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 8s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 59s | 4.x passed |
| +0 :ok: | spotbugs | 4m 41s | root in 4.x has 1020 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 3m 39s | phoenix-core in 4.x has 951 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 7s | the patch passed |
| +1 :green_heart: | compile | 1m 49s | the patch passed |
| +1 :green_heart: | javac | 1m 49s | the patch passed |
| -1 :x: | checkstyle | 2m 43s | root: The patch generated 383 new +
5842 unchanged - 49 fixed = 6225 total (was 5891) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 20s | the patch passed |
| -1 :x: | spotbugs | 3m 35s | phoenix-core generated 4 new + 951
unchanged - 0 fixed = 955 total (was 951) |
| -1 :x: | spotbugs | 4m 53s | root generated 4 new + 1020 unchanged -
0 fixed = 1024 total (was 1020) |
||| _ Other Tests _ |
| -1 :x: | unit | 212m 28s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate
ASF License warnings. |
| | | 270m 9s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be
package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
|
| | org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose
internal representation by returning RangeHistogram.ranges At
RangeHistogram.java:by returning RangeHistogram.ranges At
RangeHistogram.java:[line 75] |
| | new org.apache.phoenix.monitoring.RangeHistogram(long[], String,
String) may expose internal representation by storing an externally mutable
object into RangeHistogram.ranges At RangeHistogram.java:expose internal
representation by storing an externally mutable object into
RangeHistogram.ranges At RangeHistogram.java:[line 41] |
| | org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be
both final and package protected At SizeHistogram.java:and package protected
At SizeHistogram.java:[line 32] |
| FindBugs | module:root |
| | org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be
package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
|
| | org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose
internal representation by returning RangeHistogram.ranges At
RangeHistogram.java:by returning RangeHistogram.ranges At
RangeHistogram.java:[line 75] |
| | new org.apache.phoenix.monitoring.RangeHistogram(long[], String,
String) may expose internal representation by storing an externally mutable
object into RangeHistogram.ranges At RangeHistogram.java:expose internal
representation by storing an externally mutable object into
RangeHistogram.ranges At RangeHistogram.java:[line 41] |
| | org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be
both final and package protected At SizeHistogram.java:and package protected
At SizeHistogram.java:[line 32] |
| Failed junit tests | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1231 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaseanti checkstyle |
| uname | Linux 7b4476c7a37b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 69a9ec3 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/new-spotbugs-root.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/testReport/
|
| Max. process+thread count | 4997 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Histograms for Table level Metrics.
> ----------------------------------------
>
> Key: PHOENIX-5838
> URL: https://issues.apache.org/jira/browse/PHOENIX-5838
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: vikas meka
> Assignee: vikas meka
> Priority: Major
> Labels: metric-collector, metrics
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
