[
https://issues.apache.org/jira/browse/PHOENIX-6474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349491#comment-17349491
]
ASF GitHub Bot commented on PHOENIX-6474:
-----------------------------------------
stoty commented on pull request #1237:
URL: https://github.com/apache/phoenix/pull/1237#issuecomment-846279839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ PHOENIX-6387-4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 13s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | compile | 1m 1s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | checkstyle | 1m 48s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | javadoc | 0m 44s | PHOENIX-6387-4.x passed |
| +0 :ok: | spotbugs | 2m 56s | phoenix-core in PHOENIX-6387-4.x has
950 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 43s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 1m 50s | phoenix-core: The patch generated 102
new + 3215 unchanged - 57 fixed = 3317 total (was 3272) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 11s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 224m 46s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 42s | The patch does not generate
ASF License warnings. |
| | | 268m 19s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.monitoring.PhoenixMetricsIT |
| | phoenix.monitoring.PhoenixLoggingMetricsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1237 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux a44a252f72db 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | PHOENIX-6387-4.x / 7eba973 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/testReport/
|
| Max. process+thread count | 5074 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add client and server metrics for atomic upserts
> ------------------------------------------------
>
> Key: PHOENIX-6474
> URL: https://issues.apache.org/jira/browse/PHOENIX-6474
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Tanuj Khurana
> Assignee: Tanuj Khurana
> Priority: Major
>
> Use PHOENIX-5837 to add table level metrics for atomic upserts
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
