stoty commented on a change in pull request #54:
URL: https://github.com/apache/phoenix-connectors/pull/54#discussion_r647548201
##########
File path: phoenix-hive-base/phoenix4-hive-shaded/pom.xml
##########
@@ -48,6 +48,62 @@
<artifactId>phoenix-hbase-compat-${hbase.compat.version}</artifactId>
<scope>runtime</scope>
</dependency>
+ <!-- maven-shade-plugin doesn't ingerit dependency settings, we must
duplocate them to avoid
Review comment:
please fix the typos before commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
