[
https://issues.apache.org/jira/browse/PHOENIX-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359421#comment-17359421
]
ASF GitHub Bot commented on PHOENIX-6490:
-----------------------------------------
stoty commented on a change in pull request #54:
URL: https://github.com/apache/phoenix-connectors/pull/54#discussion_r647548201
##########
File path: phoenix-hive-base/phoenix4-hive-shaded/pom.xml
##########
@@ -48,6 +48,62 @@
<artifactId>phoenix-hbase-compat-${hbase.compat.version}</artifactId>
<scope>runtime</scope>
</dependency>
+ <!-- maven-shade-plugin doesn't ingerit dependency settings, we must
duplocate them to avoid
Review comment:
please fix the typos before commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix shaded phoenix hive connector jar name and reduce the size
> --------------------------------------------------------------
>
> Key: PHOENIX-6490
> URL: https://issues.apache.org/jira/browse/PHOENIX-6490
> Project: Phoenix
> Issue Type: Task
> Components: connectors
> Reporter: Richárd Antal
> Assignee: Richárd Antal
> Priority: Major
>
> We have these 2 artifact for the shaded hive connector:
> phoenix5-hive-shaded-6.0.0-SNAPSHOT-shaded.jar ~ 105 MB
> phoenix5-hive-shaded-6.0.0-SNAPSHOT.jar ~ 10 KB
> We have the later one in the assembly.
> Also before the latest commits the size of shaded jar was smaller.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
