[
https://issues.apache.org/jira/browse/PHOENIX-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370426#comment-17370426
]
Hadoop QA commented on PHOENIX-6458:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 5m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
49s{color} | {color:green} master passed {color} |
| {color:black}+0{color} | {color:black} hbaserecompile {color} | {color:black}
31m 41s{color} | {color:black} HBase recompiled. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
22s{color} | {color:blue} phoenix-core in master has 965 extant spotbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
23s{color} | {color:green} the patch passed {color} |
| {color:black}+0{color} | {color:black} hbaserecompile {color} | {color:black}
26m 42s{color} | {color:black} HBase recompiled. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
51s{color} | {color:red} phoenix-core: The patch generated 129 new + 4749
unchanged - 112 fixed = 4878 total (was 4861) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m
33s{color} | {color:red} phoenix-core generated 3 new + 963 unchanged - 2 fixed
= 966 total (was 965) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 38s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 9s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.schema.IndexDataColumnRef doesn't override
ColumnRef.equals(Object) At IndexDataColumnRef.java:At
IndexDataColumnRef.java:[line 1] |
| | Possible null pointer dereference of table in
org.apache.phoenix.util.IndexUtil.wrapResultUsingOffset(RegionCoprocessorEnvironment,
List, Scan, int, ColumnReference[], TupleProjector, Region, IndexMaintainer,
byte[][], ImmutableBytesWritable) Dereferenced at IndexUtil.java:table in
org.apache.phoenix.util.IndexUtil.wrapResultUsingOffset(RegionCoprocessorEnvironment,
List, Scan, int, ColumnReference[], TupleProjector, Region, IndexMaintainer,
byte[][], ImmutableBytesWritable) Dereferenced at IndexUtil.java:[line 602] |
| | Possible null pointer dereference of table in
org.apache.phoenix.util.IndexUtil.wrapResultUsingOffset(RegionCoprocessorEnvironment,
List, Scan, int, ColumnReference[], TupleProjector, Region, IndexMaintainer,
byte[][], ImmutableBytesWritable) Dereferenced at IndexUtil.java:table in
org.apache.phoenix.util.IndexUtil.wrapResultUsingOffset(RegionCoprocessorEnvironment,
List, Scan, int, ColumnReference[], TupleProjector, Region, IndexMaintainer,
byte[][], ImmutableBytesWritable) Dereferenced at IndexUtil.java:[line 602] |
| Failed junit tests | phoenix.compile.QueryOptimizerTest |
| | phoenix.compile.TenantSpecificViewIndexCompileTest |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/393/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6458 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13027336/PHOENIX-6458.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild
hbaseanti checkstyle compile |
| uname | Linux e3de1e60cecd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / fcdf5bc |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/393/artifact/patchprocess/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/393/artifact/patchprocess/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/393/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/393/testReport/ |
| Max. process+thread count | 502 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/393/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Using global indexes for queries with uncovered columns
> -------------------------------------------------------
>
> Key: PHOENIX-6458
> URL: https://issues.apache.org/jira/browse/PHOENIX-6458
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0
> Reporter: Kadir Ozdemir
> Priority: Major
> Attachments: PHOENIX-6458.master.001.patch
>
>
> Phoenix client does not use a global index for the queries with the columns
> that are not covered by the global index. However, there are many cases where
> using the global index to map secondary keys to primary keys and then
> retrieving the corresponding rows from the data table results in faster
> queries. It is expected that such performance improvement will happen when
> the index row key prefix length is greater than the data row key prefix
> length for a given query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
