lhofhansl commented on a change in pull request #1256:
URL: https://github.com/apache/phoenix/pull/1256#discussion_r659498128
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java
##########
@@ -302,7 +306,8 @@ private void appendPKColumnValue(StringBuilder buf, byte[]
range, Boolean isNull
private Long getViewIndexValue(PDataType type, byte[] range) {
boolean useLongViewIndex =
MetaDataUtil.getViewIndexIdDataType().equals(type);
Object s = type.toObject(range);
- return (useLongViewIndex ? (Long) s : (Short) s) + Short.MAX_VALUE + 2;
+ //return (useLongViewIndex ? (Long) s : (Short) s) + Short.MAX_VALUE +
2;
+ return (useLongViewIndex ? (Long) s : 0) + Short.MAX_VALUE + 2;
Review comment:
I suspect this will cause some very tricky backwards compatibility issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
