[
https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371777#comment-17371777
]
ASF GitHub Bot commented on PHOENIX-6395:
-----------------------------------------
stoty commented on pull request #1152:
URL: https://github.com/apache/phoenix/pull/1152#issuecomment-871053501
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 30s | 4.x passed |
| +1 :green_heart: | compile | 1m 5s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 33s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x passed |
| +0 :ok: | spotbugs | 3m 20s | phoenix-core in 4.x has 957 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 55s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| -1 :x: | checkstyle | 0m 35s | phoenix-core: The patch generated 17
new + 313 unchanged - 12 fixed = 330 total (was 325) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 28s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 205m 12s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate
ASF License warnings. |
| | | 253m 49s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.PermissionsCacheIT |
| | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.PermissionNSDisabledIT |
| | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT |
| | phoenix.end2end.PermissionNSEnabledIT |
| | phoenix.end2end.AuditLoggingIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1152 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 8c679e5fca3b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / dd9b8af |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/
|
| Max. process+thread count | 4716 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Reusing Connection instance object instead of creating everytime in
> PhoenixAccessController class.
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6395
> URL: https://issues.apache.org/jira/browse/PHOENIX-6395
> Project: Phoenix
> Issue Type: Bug
> Reporter: vikas meka
> Assignee: vikas meka
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)