[
https://issues.apache.org/jira/browse/PHOENIX-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377996#comment-17377996
]
ASF GitHub Bot commented on PHOENIX-6507:
-----------------------------------------
stoty commented on pull request #1262:
URL: https://github.com/apache/phoenix/pull/1262#issuecomment-877095464
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 18m 29s | 4.x passed |
| +1 :green_heart: | compile | 1m 4s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 28s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 50s | 4.x passed |
| +0 :ok: | spotbugs | 3m 13s | phoenix-core in 4.x has 957 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 5s | the patch passed |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -1 :x: | checkstyle | 0m 27s | phoenix-core: The patch generated 17
new + 74 unchanged - 24 fixed = 91 total (was 98) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| -1 :x: | spotbugs | 3m 26s | phoenix-core generated 2 new + 957
unchanged - 0 fixed = 959 total (was 957) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 143m 16s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate
ASF License warnings. |
| | | 189m 40s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | new org.apache.phoenix.expression.KeyValueColumnExpression(byte[],
byte[]) may expose internal representation by storing an externally mutable
object into KeyValueColumnExpression.cf At
KeyValueColumnExpression.java:internal representation by storing an externally
mutable object into KeyValueColumnExpression.cf At
KeyValueColumnExpression.java:[line 49] |
| | new org.apache.phoenix.expression.KeyValueColumnExpression(byte[],
byte[]) may expose internal representation by storing an externally mutable
object into KeyValueColumnExpression.cq At
KeyValueColumnExpression.java:internal representation by storing an externally
mutable object into KeyValueColumnExpression.cq At
KeyValueColumnExpression.java:[line 50] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1262/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1262 |
| JIRA Issue | PHOENIX-6507 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 1b4a7361e0c0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / ddd7ff6 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1262/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1262/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1262/1/testReport/
|
| Max. process+thread count | 5885 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1262/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> DistinctAggregatingResultIterator should keep original tuple order of the
> AggregatingResultIterator
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6507
> URL: https://issues.apache.org/jira/browse/PHOENIX-6507
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.16.1, 5.1.2
> Reporter: chenglei
> Assignee: chenglei
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
>
> Given following tables :
> {code:java}
> create table test (
> pk1 varchar not null ,
> pk2 varchar not null,
> pk3 varchar not null,
> v1 varchar,
> v2 varchar,
> CONSTRAINT TEST_PK PRIMARY KEY ( pk1,pk2,pk3))
> {code}
> The result of the following sql may be incorrect:
> {code:java}
> select distinct pk1,max(v1) from test group by pk1,pk2,pk3 order by pk1
> {code}
> The problem is the {{order by}} is complied out because it is the prefix of
> the {{group by}}, but for {{distinct}},
> {{DistinctAggregatingResultIterator}} using {{HashSet}} to rearrange the
> aggregated tuples.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
