stoty commented on pull request #1272: URL: https://github.com/apache/phoenix/pull/1272#issuecomment-885077726
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 5.1 Compile Tests _ | | +0 :ok: | mvndep | 5m 2s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 16m 55s | 5.1 passed | | +0 | hbaserecompile | 28m 38s | HBase recompiled. | | +1 :green_heart: | compile | 1m 31s | 5.1 passed | | +1 :green_heart: | checkstyle | 0m 57s | 5.1 passed | | +1 :green_heart: | javadoc | 1m 13s | 5.1 passed | | +0 :ok: | spotbugs | 3m 7s | phoenix-core in 5.1 has 951 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 44s | phoenix-tools in 5.1 has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 15m 32s | the patch passed | | +0 | hbaserecompile | 24m 16s | HBase recompiled. | | +1 :green_heart: | compile | 2m 12s | the patch passed | | +1 :green_heart: | javac | 2m 12s | the patch passed | | -1 :x: | checkstyle | 0m 52s | phoenix-core: The patch generated 42 new + 359 unchanged - 10 fixed = 401 total (was 369) | | -1 :x: | checkstyle | 0m 23s | phoenix-tools: The patch generated 201 new + 220 unchanged - 42 fixed = 421 total (was 262) | | -1 :x: | whitespace | 0m 1s | The patch 2 line(s) with tabs. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 29s | the patch passed | | -1 :x: | spotbugs | 1m 14s | phoenix-tools generated 5 new + 0 unchanged - 3 fixed = 5 total (was 3) | ||| _ Other Tests _ | | -1 :x: | unit | 116m 4s | phoenix-core in the patch failed. | | -1 :x: | unit | 4m 8s | phoenix-tools in the patch failed. | | +1 :green_heart: | asflicense | 1m 20s | The patch does not generate ASF License warnings. | | | | 197m 21s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-tools | | | Found reliance on default encoding in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String): new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 212] | | | org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String) may fail to close stream At SchemaSynthesisProcessor.java:stream At SchemaSynthesisProcessor.java:[line 212] | | | org.apache.phoenix.schema.SchemaTool.conf should be package protected In SchemaTool.java: In SchemaTool.java | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:[line 114] | | | Write to static field org.apache.phoenix.schema.SchemaTool.conf from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line 73] | | Failed junit tests | phoenix.end2end.index.IndexMetadataIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1272 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml | | uname | Linux e084ac051a8b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 5.1 / ad7e742 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/testReport/ | | Max. process+thread count | 11217 (vs. ulimit of 30000) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1272/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
