[
https://issues.apache.org/jira/browse/PHOENIX-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388721#comment-17388721
]
ASF GitHub Bot commented on PHOENIX-6518:
-----------------------------------------
stoty commented on pull request #1271:
URL: https://github.com/apache/phoenix/pull/1271#issuecomment-888237844
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 58s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 58s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 21m 55s | master passed |
| +0 | hbaserecompile | 35m 21s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 56s | master passed |
| +1 :green_heart: | checkstyle | 1m 50s | master passed |
| +1 :green_heart: | javadoc | 1m 20s | master passed |
| +0 :ok: | spotbugs | 3m 56s | phoenix-core in master has 964 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 50s | phoenix-tools in master has 5 extant
spotbugs warnings. |
| -0 :warning: | patch | 1m 7s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 17m 27s | the patch passed |
| +0 | hbaserecompile | 24m 17s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 38s | the patch passed |
| -1 :x: | checkstyle | 1m 34s | phoenix-core: The patch generated 408
new + 2638 unchanged - 0 fixed = 3046 total (was 2638) |
| -1 :x: | checkstyle | 0m 16s | phoenix-tools: The patch generated 3
new + 57 unchanged - 364 fixed = 60 total (was 421) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 9s | the patch passed |
| -1 :x: | spotbugs | 3m 23s | phoenix-core generated 6 new + 964
unchanged - 0 fixed = 970 total (was 964) |
| +1 :green_heart: | spotbugs | 0m 52s | phoenix-tools generated 0 new
+ 3 unchanged - 2 fixed = 3 total (was 5) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 116m 53s | phoenix-core in the patch passed.
|
| -1 :x: | unit | 3m 23s | phoenix-tools in the patch failed. |
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate
ASF License warnings. |
| | | 202m 12s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Found reliance on default encoding in
org.apache.phoenix.schematool.SchemaSynthesisProcessor.getQueriesFromFile(String):in
org.apache.phoenix.schematool.SchemaSynthesisProcessor.getQueriesFromFile(String):
new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 211] |
| | Null passed for non-null parameter of new
org.apache.phoenix.parse.SQLParser(String) in
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String,
String) Method invoked at SchemaSynthesisProcessor.java:of new
org.apache.phoenix.parse.SQLParser(String) in
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String,
String) Method invoked at SchemaSynthesisProcessor.java:[line 80] |
| | Null passed for non-null parameter of new
org.apache.phoenix.parse.SQLParser(String) in
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String,
String) Method invoked at SchemaSynthesisProcessor.java:of new
org.apache.phoenix.parse.SQLParser(String) in
org.apache.phoenix.schematool.SchemaSynthesisProcessor.synthesize(String,
String) Method invoked at SchemaSynthesisProcessor.java:[line 81] |
| |
org.apache.phoenix.schematool.SchemaSynthesisProcessor.getQueriesFromFile(String)
may fail to close stream At SchemaSynthesisProcessor.java:stream At
SchemaSynthesisProcessor.java:[line 211] |
| | Invocation of toString on Throwable.getStackTrace() in
org.apache.phoenix.util.QueryUtil.getShowCreateStatementStmt(PhoenixConnection,
String, TableName) At QueryUtil.java:in
org.apache.phoenix.util.QueryUtil.getShowCreateStatementStmt(PhoenixConnection,
String, TableName) At QueryUtil.java:[line 788] |
| |
org.apache.phoenix.util.QueryUtil.getShowCreateStatementStmt(PhoenixConnection,
String, TableName) may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:[line 794] is not discharged |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1271 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 4a5cb0890046 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9b76bd5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/testReport/
|
| Max. process+thread count | 14392 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-tools U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1271/3/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement SHOW CREATE STATEMENT SQL command
> -------------------------------------------
>
> Key: PHOENIX-6518
> URL: https://issues.apache.org/jira/browse/PHOENIX-6518
> Project: Phoenix
> Issue Type: Task
> Components: core
> Reporter: Richárd Antal
> Assignee: Richárd Antal
> Priority: Major
>
> With PHOENIX-5946 and PHOENIX-6454 it is possible to generate effective DDL
> for a table/view/index using the SchemaTool and an hbase command.
> Implement SHOW CREATE STATEMENT sql command to further utilize this
> functionality.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
