[
https://issues.apache.org/jira/browse/PHOENIX-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389852#comment-17389852
]
ASF GitHub Bot commented on PHOENIX-5422:
-----------------------------------------
stoty commented on pull request #1277:
URL: https://github.com/apache/phoenix/pull/1277#issuecomment-889061134
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
4 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 3s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 18m 7s | master passed |
| +0 | hbaserecompile | 30m 35s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 50s | master passed |
| +1 :green_heart: | checkstyle | 1m 6s | master passed |
| +1 :green_heart: | javadoc | 1m 21s | master passed |
| +0 :ok: | spotbugs | 3m 31s | phoenix-core in master has 964 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 55s | phoenix-pherf in master has 54 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 16m 9s | the patch passed |
| +0 | hbaserecompile | 23m 15s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| -1 :x: | checkstyle | 0m 46s | phoenix-core: The patch generated 87
new + 471 unchanged - 75 fixed = 558 total (was 546) |
| -1 :x: | checkstyle | 0m 23s | phoenix-pherf: The patch generated 13
new + 266 unchanged - 15 fixed = 279 total (was 281) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 18s | the patch passed |
| -1 :x: | spotbugs | 3m 43s | phoenix-core generated 6 new + 964
unchanged - 0 fixed = 970 total (was 964) |
||| _ Other Tests _ |
| -1 :x: | unit | 115m 28s | phoenix-core in the patch failed. |
| +1 :green_heart: | unit | 9m 30s | phoenix-pherf in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 16s | The patch does not generate
ASF License warnings. |
| | | 202m 32s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.expression.function.RoundJavaDateExpression.correction
should be package protected In RoundJavaDateExpression.java: In
RoundJavaDateExpression.java |
| | org.apache.phoenix.expression.function.RoundJavaDateExpression.week
should be package protected In RoundJavaDateExpression.java: In
RoundJavaDateExpression.java |
| | Write to static field
org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from
instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression() At
RoundJavaDateExpression.java:from instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression() At
RoundJavaDateExpression.java:[line 46] |
| | Write to static field
org.apache.phoenix.expression.function.RoundJavaDateExpression.week from
instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression() At
RoundJavaDateExpression.java:from instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression() At
RoundJavaDateExpression.java:[line 43] |
| | Write to static field
org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from
instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At
RoundJavaDateExpression.java:from instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At
RoundJavaDateExpression.java:[line 46] |
| | Write to static field
org.apache.phoenix.expression.function.RoundJavaDateExpression.week from
instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At
RoundJavaDateExpression.java:from instance method new
org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At
RoundJavaDateExpression.java:[line 43] |
| Failed junit tests |
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1277 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaserebuild hbaseanti checkstyle |
| uname | Linux 1233afd12a1c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9b76bd5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/testReport/
|
| Max. process+thread count | 13454 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Use Java8 DateTime APIs instead of joda-time APIs
> -------------------------------------------------
>
> Key: PHOENIX-5422
> URL: https://issues.apache.org/jira/browse/PHOENIX-5422
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 4.8.0
> Reporter: Naveen Gangam
> Assignee: Richárd Antal
> Priority: Minor
> Attachments: PHOENIX-5422.master.v1.patch,
> PHOENIX-5422.master.v2.patch, PHOENIX-5422.master.v3.patch,
> PHOENIX-5422.master.v4.patch
>
>
> currently, phoenix-hive.jar bundles an old version of joda-time library.
> Java8 has new DateTime APIs are similar in to the joda-time APIs in features.
> It would make sense to eliminate a dependency on external library that may or
> may not be
> a) Actively developed
> b) not guaranteed to be backward compatible with older APIs and could involve
> code changes as well.
> Its is better to move using JDK8 APIs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
