[
https://issues.apache.org/jira/browse/PHOENIX-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389982#comment-17389982
]
ASF GitHub Bot commented on PHOENIX-6519:
-----------------------------------------
stoty commented on pull request #1275:
URL: https://github.com/apache/phoenix/pull/1275#issuecomment-889253893
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 5s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 42s | master passed |
| +0 | hbaserecompile | 33m 45s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 51s | master passed |
| +1 :green_heart: | checkstyle | 1m 9s | master passed |
| +1 :green_heart: | javadoc | 1m 26s | master passed |
| +0 :ok: | spotbugs | 4m 18s | phoenix-core in master has 970 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 52s | phoenix-tools in master has 3 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 16m 34s | the patch passed |
| +0 | hbaserecompile | 23m 34s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 46s | the patch passed |
| +1 :green_heart: | javac | 1m 46s | the patch passed |
| -1 :x: | checkstyle | 0m 46s | phoenix-core: The patch generated 65
new + 909 unchanged - 27 fixed = 974 total (was 936) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed |
| +1 :green_heart: | spotbugs | 4m 59s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 123m 16s | phoenix-core in the patch failed. |
| -1 :x: | unit | 3m 58s | phoenix-tools in the patch failed. |
| +1 :green_heart: | asflicense | 1m 24s | The patch does not generate
ASF License warnings. |
| | | 214m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1275 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux da3954fc0345 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / d04b3d8 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/testReport/
|
| Max. process+thread count | 13954 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-tools U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Make SchemaTool work with lower case table and column names
> -----------------------------------------------------------
>
> Key: PHOENIX-6519
> URL: https://issues.apache.org/jira/browse/PHOENIX-6519
> Project: Phoenix
> Issue Type: Task
> Components: core
> Reporter: Richárd Antal
> Assignee: Richárd Antal
> Priority: Major
>
> I wrote this test as part of a PR for PHOENIX-6518 and it fails.
> {code:java}
> @Test
> public void testCreateTableStatementLowerCase() throws Exception {
> String tableName = "lowecasetbl1";
> String schemaName = "lowecaseschemaname1";
> String pTableFullName = SchemaUtil.getEscapedTableName(schemaName,
> tableName);
> String createTableStmt = "CREATE TABLE "+ pTableFullName +
> "(\"smallK\" VARCHAR NOT NULL PRIMARY KEY, "
> + "V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE,
> DISABLE_WAL=TRUE";
> List<String> queries = new ArrayList<String>(){};
> queries.add(createTableStmt);
> String result = runSchemaExtractionTool("\"" + schemaName + "\"",
> "\"" + tableName + "\"", null, queries);
> Assert.assertEquals(createTableStmt, result.toUpperCase());
> }{code}
> Expected:
> {code:java}
> CREATE TABLE "lowecaseschemaname1"."lowecasetbl1"("smallK" VARCHAR NOT NULL
> PRIMARY KEY, V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE,
> DISABLE_WAL=TRUE{code}
> Actual result:
> {code:java}
> CREATE TABLE LOWECASESCHEMANAME1.LOWECASETBL1(SMALLK VARCHAR NOT NULL PRIMARY
> KEY, V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE,
> DISABLE_WAL=TRUE{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
