[
https://issues.apache.org/jira/browse/PHOENIX-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390704#comment-17390704
]
ASF GitHub Bot commented on PHOENIX-6480:
-----------------------------------------
stoty commented on pull request #1279:
URL: https://github.com/apache/phoenix/pull/1279#issuecomment-890042482
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 0s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 17m 9s | master passed |
| +0 | hbaserecompile | 28m 47s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 51s | master passed |
| +1 :green_heart: | checkstyle | 1m 14s | master passed |
| +1 :green_heart: | javadoc | 2m 58s | master passed |
| +0 :ok: | spotbugs | 4m 54s | root in master has 1032 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 3m 5s | phoenix-core in master has 970 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 39s | phoenix-tools in master has 3 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 14m 6s | the patch passed |
| +0 | hbaserecompile | 20m 28s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 40s | the patch passed |
| +1 :green_heart: | javac | 1m 40s | the patch passed |
| -1 :x: | checkstyle | 1m 6s | root: The patch generated 27 new + 317
unchanged - 25 fixed = 344 total (was 342) |
| -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 21s | the patch passed |
| -1 :x: | spotbugs | 3m 29s | phoenix-core generated 3 new + 970
unchanged - 0 fixed = 973 total (was 970) |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 25s | root in the patch failed. |
| -1 :x: | asflicense | 2m 24s | The patch generated 614 ASF License
warnings. |
| | | 209m 25s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.schema.tool.SchemaTool.conf should be package
protected In SchemaTool.java: In SchemaTool.java |
| | Possible null pointer dereference of cmdLine in
org.apache.phoenix.schema.tool.SchemaTool.parseOptions(String[]) Dereferenced
at SchemaTool.java:cmdLine in
org.apache.phoenix.schema.tool.SchemaTool.parseOptions(String[]) Dereferenced
at SchemaTool.java:[line 114] |
| | Write to static field org.apache.phoenix.schema.tool.SchemaTool.conf
from instance method org.apache.phoenix.schema.tool.SchemaTool.run(String[])
At SchemaTool.java:from instance method
org.apache.phoenix.schema.tool.SchemaTool.run(String[]) At
SchemaTool.java:[line 73] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1279 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaserebuild hbaseanti checkstyle |
| uname | Linux 5ebc2ecf8639 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / a4f0304 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 9680 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-assembly . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1279/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> SchemaExtractionProcessor doesn't add IMMUTABLE_STORAGE_SCHEME and
> COLUMN_ENCODED_BYTES to the generated sql
> ------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6480
> URL: https://issues.apache.org/jira/browse/PHOENIX-6480
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
>
> convertPropertiesToString function has a check
> if(value!=null && defaultProps.get(key) != null &&
> !value.equals(defaultProps.get(key)))
> Since the value is not in defaultProps, it doesn't add it to the generated
> ddl.
> Also, is it possible to do IF NOT EXISTS to CREATE statement and ASYNC
> perhaps?
> Also move the phoenix-tools util into phoenix-core to avoid circular
> dependency
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
