[
https://issues.apache.org/jira/browse/PHOENIX-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401291#comment-17401291
]
ASF GitHub Bot commented on PHOENIX-4917:
-----------------------------------------
stoty commented on pull request #358:
URL: https://github.com/apache/phoenix/pull/358#issuecomment-901329549
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 21m 1s | master passed |
| +0 | hbaserecompile | 32m 23s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 4s | master passed |
| +1 :green_heart: | checkstyle | 0m 56s | master passed |
| +1 :green_heart: | javadoc | 0m 53s | master passed |
| +0 :ok: | spotbugs | 3m 5s | phoenix-core in master has 972 extant
spotbugs warnings. |
| -0 :warning: | patch | 3m 14s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 30s | root in the patch failed. |
| +0 | hbaserecompile | 15m 25s | HBase recompiled. |
| -1 :x: | compile | 0m 20s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 20s | phoenix-core in the patch failed. |
| +1 :green_heart: | checkstyle | 0m 55s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 :x: | whitespace | 0m 0s | The patch 30 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed |
| -1 :x: | spotbugs | 0m 18s | phoenix-core in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 19s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate
ASF License warnings. |
| | | 60m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/358 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 7704385c681c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / bfc4621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/testReport/
|
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> ClassCastException when projecting array elements in hash join
> --------------------------------------------------------------
>
> Key: PHOENIX-4917
> URL: https://issues.apache.org/jira/browse/PHOENIX-4917
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Gerald Sangudi
> Assignee: Gerald Sangudi
> Priority: Blocker
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4917.patch, PHOENIX-4917.patch,
> PHOENIX-4917.patch, PHOENIX-4917.patch
>
>
> This bug was introduced in the fix for PHOENIX-4791.
> When projecting array elements in hash join, we now generate both
> ProjectedTupleValue and MultiKeyTupleValue. Before the fix for PHOENIX-4791,
> hash join was only generating ProjectedTupleValue, and there were two lines
> of code with class casts that reflected this assumption. The fix is to handle
> both ProjectedTupleValue and MultiKeyTupleValue, while continuing to
> propagate the array cell as in PHOENIX-4791.
>
> The stack trace with the ClassCastException:
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> org.apache.hadoop.hbase.DoNotRetryIOException:
> GENO_DOSE,,1537598769044.1a6cb8853b036c59e7515d8e876e28c5.:
> org.apache.phoenix.schema.tuple.MultiKeyValueTuple cannot be cast to
> org.apache.phoenix.execute.TupleProjector$ProjectedValueTuple
> at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:96)
> at org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:62)
> at
> org.apache.phoenix.coprocessor.HashJoinRegionScanner.nextRaw(HashJoinRegionScanner.java:300)
> at
> org.apache.phoenix.coprocessor.DelegateRegionScanner.nextRaw(DelegateRegionScanner.java:82)
> at
> org.apache.phoenix.coprocessor.DelegateRegionScanner.nextRaw(DelegateRegionScanner.java:82)
> at
> org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.nextRaw(BaseScannerRegionObserver.java:294)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2633)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2837)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:34950)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2339)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> Caused by: java.lang.ClassCastException:
> org.apache.phoenix.schema.tuple.MultiKeyValueTuple cannot be cast to
> org.apache.phoenix.execute.TupleProjector$ProjectedValueTuple
> at
> org.apache.phoenix.coprocessor.HashJoinRegionScanner.processResults(HashJoinRegionScanner.java:220)
> at
> org.apache.phoenix.coprocessor.HashJoinRegionScanner.nextRaw(HashJoinRegionScanner.java:294)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
