[ 
https://issues.apache.org/jira/browse/PHOENIX-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410423#comment-17410423
 ] 

ASF GitHub Bot commented on PHOENIX-6365:
-----------------------------------------

stoty commented on a change in pull request #1133:
URL: https://github.com/apache/phoenix/pull/1133#discussion_r702646987



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java
##########
@@ -985,7 +976,17 @@ public TableRef refreshDerivedTableNode(DerivedTableNode 
derivedTableNode) throw
               return this.resolveTable(null, tableAlias);
         }
 
-        private static class ColumnFamilyRef {
+        protected void rememberTable(TableRef tableRef, String alias) {
+            String name = tableRef.getTable().getName().getString();
+            if (alias != null) {
+                tableMap.put(alias, tableRef);
+            } else {
+                tableMap.put(name, tableRef);
+            }
+            tables.add(tableRef);
+        }
+
+        protected static class ColumnFamilyRef {

Review comment:
       Actually, It doesn't do anything. 
   I have removed both ColumnFamilyRef and resolveColumnFamily, which is never 
calles.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bogus AmbiguousTableException in query with aliases on local indexed tables
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-6365
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6365
>             Project: Phoenix
>          Issue Type: Task
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Certain queries with aliases on tbales with local indexes throw 
> AmbiguousTableException



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to