stoty commented on a change in pull request #1299:
URL: https://github.com/apache/phoenix/pull/1299#discussion_r705873197
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
##########
@@ -109,20 +109,20 @@ private void snapshotAllMetrics(MetricRegistry
metricRegistry,
Map<String, Metric> metrics = metricRegistry.getMetrics();
Iterator iterator = metrics.entrySet().iterator();
- while (iterator.hasNext()) {
- Entry<String, Metric> e = (Entry) iterator.next();
+ while(iterator.hasNext()) {
+ Entry<String, Metric> e = (Entry)iterator.next();
Review comment:
Thanks, fixed.
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ScanningResultIterator.java
##########
@@ -97,9 +95,7 @@ private void changeMetric(GlobalClientMetrics metric, Long
value) {
private void updateMetrics() {
if (scanMetricsEnabled && !scanMetricsUpdated) {
- ScanMetrics scanMetrics = scan.getScanMetrics();
- if (scanMetrics == null)
Review comment:
I realize that we also lose the "scan" class variable, but it is not
used, and is overridden in child classes anyway, so that's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
