gokceni commented on a change in pull request #1300:
URL: https://github.com/apache/phoenix/pull/1300#discussion_r706502746
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -610,7 +610,9 @@ public static void
setTimestamps(MiniBatchOperationInProgress<Mutation> miniBatc
}
Mutation m = miniBatchOp.getOperation(i);
// skip this mutation if we aren't enabling indexing or not an
atomic op
- if (!builder.isEnabled(m) && !builder.isAtomicOp(m)) {
+ // or if it is an atomic op and its timestamp is already set
+ if (!builder.isEnabled(m) &&
+ (!builder.isAtomicOp(m) || getMaxTimestamp(m) !=
HConstants.LATEST_TIMESTAMP)) {
Review comment:
Should this be && rather than ||? The comment says "and" not "or"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
