[
https://issues.apache.org/jira/browse/PHOENIX-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413416#comment-17413416
]
ASF GitHub Bot commented on PHOENIX-6541:
-----------------------------------------
gokceni commented on a change in pull request #1300:
URL: https://github.com/apache/phoenix/pull/1300#discussion_r706502746
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -610,7 +610,9 @@ public static void
setTimestamps(MiniBatchOperationInProgress<Mutation> miniBatc
}
Mutation m = miniBatchOp.getOperation(i);
// skip this mutation if we aren't enabling indexing or not an
atomic op
- if (!builder.isEnabled(m) && !builder.isAtomicOp(m)) {
+ // or if it is an atomic op and its timestamp is already set
+ if (!builder.isEnabled(m) &&
+ (!builder.isAtomicOp(m) || getMaxTimestamp(m) !=
HConstants.LATEST_TIMESTAMP)) {
Review comment:
Should this be && rather than ||? The comment says "and" not "or"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Use ROW_TIMESTAMP column value as timestamps for conditional upsert mutations
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-6541
> URL: https://issues.apache.org/jira/browse/PHOENIX-6541
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.16.1, 5.1.2
> Reporter: Tanuj Khurana
> Assignee: Tanuj Khurana
> Priority: Major
>
> For tables without indexes if ROW_TIMESTAMP is specified in the table DDL,
> the mutations generated by conditional upserts don't have the correct
> timestamp. This was introduced as part of [PHOENIX-6387]
> For tables with indexes, Phoenix doesn't allow specifying a PK column as
> ROW_TIMESTAMP so this bug doesn't apply.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
