[
https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417637#comment-17417637
]
ASF GitHub Bot commented on PHOENIX-6523:
-----------------------------------------
stoty commented on pull request #1280:
URL: https://github.com/apache/phoenix/pull/1280#issuecomment-922900664
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 53s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 21m 22s | master passed |
| +0 | hbaserecompile | 28m 3s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
| +0 :ok: | spotbugs | 3m 6s | phoenix-core in master has 972 extant
spotbugs warnings. |
| -0 :warning: | patch | 3m 15s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 25s | the patch passed |
| +0 | hbaserecompile | 23m 12s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | the patch passed |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -1 :x: | checkstyle | 1m 15s | phoenix-core: The patch generated 48
new + 734 unchanged - 18 fixed = 782 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 4 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
| -1 :x: | spotbugs | 3m 21s | phoenix-core generated 1 new + 972
unchanged - 0 fixed = 973 total (was 972) |
||| _ Other Tests _ |
| -1 :x: | unit | 161m 45s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 16s | The patch generated 7 ASF License
warnings. |
| | | 230m 39s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Class org.apache.phoenix.jdbc.MalformedUrlException is not derived
from an Exception, even though it is named as such At
MalformedUrlException.java:from an Exception, even though it is named as such
At MalformedUrlException.java:[lines 8-15] |
| Failed junit tests | phoenix.mapreduce.util.PhoenixConfigurationUtilTest |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 03f2c05daf9d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f606289 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 486 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support for HBase Registry Implementations through Phoenix connection URL
> -------------------------------------------------------------------------
>
> Key: PHOENIX-6523
> URL: https://issues.apache.org/jira/browse/PHOENIX-6523
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Ramie Raufdeen
> Priority: Major
>
> https://issues.apache.org/jira/browse/HBASE-23305
> https://issues.apache.org/jira/browse/HBASE-18095
>
> HBase now supports a zookeeper-less connection strategy using a Master
> Registry implementation.
>
> For this to work, the client simply needs to set a list of <host:port>s of
> the HMaster quorum
>
> {code:java}
> <property>
> <name>hbase.masters</name>
> <value>master1:16000,master2:16001,master3:16000</value>
> </property>
> {code}
>
> To support opting into this from a Phoenix connection URL, we can introduce a
> "connector type". We'll leverage the *+* char of [JDBC URL
> grammar|https://docs.oracle.com/cd/E17952_01/connector-j-8.0-en/connector-j-reference-jdbc-url-format.html]
> to specify the connection type. Connections will start to look something
> like this:
> {code:java}
> jdbc:phoenix+zk:hostname1,2,3...:<properties>
> jdbc:phoenix+hrpc:hostname1,2,3...:<properties>
> jdbc:phoenix+bigtable:hostname1,2,3...:<properties>{code}
> Above are examples of opting into hrpc/zk/bigtable registry implementations
> of HBase.
>
> If no connector is specified, the driver will default to a Zookeeper based
> connection.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
