[
https://issues.apache.org/jira/browse/PHOENIX-6566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424416#comment-17424416
]
ASF GitHub Bot commented on PHOENIX-6566:
-----------------------------------------
stoty commented on pull request #64:
URL: https://github.com/apache/phoenix-connectors/pull/64#issuecomment-934305579
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 10m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 20m 13s | master passed |
| +1 :green_heart: | compile | 2m 47s | master passed |
| +1 :green_heart: | javadoc | 0m 41s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 20m 0s | the patch passed |
| +1 :green_heart: | compile | 2m 47s | the patch passed |
| +1 :green_heart: | javac | 2m 47s | the patch passed |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 37m 32s | phoenix-hive-base in the patch failed. |
| -1 :x: | unit | 49m 55s | phoenix-spark-base in the patch failed. |
| -1 :x: | asflicense | 0m 15s | The patch generated 4 ASF License
warnings. |
| | | 152m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-64/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/64 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 25f6d7b57af7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18
19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 29422f1 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-64/1/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-64/1/artifact/yetus-general-check/output/patch-unit-phoenix-spark-base.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-64/1/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-64/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 1779 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base phoenix-spark-base U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-64/1/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> shaded phoenix connectors include restricitve log4j config files
> ----------------------------------------------------------------
>
> Key: PHOENIX-6566
> URL: https://issues.apache.org/jira/browse/PHOENIX-6566
> Project: Phoenix
> Issue Type: Bug
> Components: connectors, hive-connector, spark-connector
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> The phoenix-spark connector includes a restrictive log4j.xml file, which in
> some cases is used by log4j. This makes debugging the connector hard to
> impossible.
> Another logj4.properties file is coming from Omid via Phoenix, we don't want
> that one, either. (Going to open a separate ticket for Omid)
> In general, log4j configuration should be external to the binary jar
> artifacts.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
