[
https://issues.apache.org/jira/browse/PHOENIX-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425863#comment-17425863
]
ASF GitHub Bot commented on PHOENIX-6561:
-----------------------------------------
jpisaac commented on a change in pull request #1322:
URL: https://github.com/apache/phoenix/pull/1322#discussion_r723706298
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
##########
@@ -127,10 +127,16 @@
private final CompareType compareType;
private final boolean thinDriver;
private final String queryServerUrl;
+ private Properties phoenixProperties = new Properties();
@VisibleForTesting
WorkloadExecutor workloadExecutor;
+ public Pherf(String[] args, Properties phoenixProperties) throws Exception
{
Review comment:
There is also phoenix properties that can be specified as part of the
scenario.
https://github.com/apache/phoenix/blob/1a13c055afb01a2ba6e658f0dd41a753bf904555/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Scenario.java#L38
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
##########
@@ -127,10 +127,16 @@
private final CompareType compareType;
private final boolean thinDriver;
private final String queryServerUrl;
+ private Properties phoenixProperties = new Properties();
@VisibleForTesting
WorkloadExecutor workloadExecutor;
+ public Pherf(String[] args, Properties phoenixProperties) throws Exception
{
Review comment:
Why not use the existing properties field?
https://github.com/apache/phoenix/blob/1a13c055afb01a2ba6e658f0dd41a753bf904555/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow pherf to intake phoenix Connection properties as argument.
> ----------------------------------------------------------------
>
> Key: PHOENIX-6561
> URL: https://issues.apache.org/jira/browse/PHOENIX-6561
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Lokesh Khurana
> Assignee: Lokesh Khurana
> Priority: Minor
>
> Currently pherf doesn't allow connection properties to be passed as
> arguments, it allows for some cases through scenario files, but for dynamic
> properties selection that might not work, also for WriteWorkload no property
> is being allowed to pass during connection creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
