[
https://issues.apache.org/jira/browse/PHOENIX-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427371#comment-17427371
]
ASF GitHub Bot commented on PHOENIX-5838:
-----------------------------------------
yanxinyi commented on a change in pull request #1231:
URL: https://github.com/apache/phoenix/pull/1231#discussion_r726595068
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/PhoenixTableMetric.java
##########
@@ -34,4 +34,5 @@
* @return Sum of the values of the metric sampled since the last {@link
#reset()} call.
*/
public long getTotalSum();
+
Review comment:
nit: remove the extra line. Given no changes in this file.
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/PhoenixTableMetricImpl.java
##########
@@ -74,4 +74,5 @@ public PhoenixTableMetricImpl(MetricType type) {
metric.decrement();
numberOfSamples.incrementAndGet();
}
+
Review comment:
nit: remove the extra line. Given no changes in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Histograms for Table level Metrics.
> ----------------------------------------
>
> Key: PHOENIX-5838
> URL: https://issues.apache.org/jira/browse/PHOENIX-5838
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: vikas meka
> Assignee: vikas meka
> Priority: Major
> Labels: metric-collector, metrics
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
