jpisaac commented on a change in pull request #1322:
URL: https://github.com/apache/phoenix/pull/1322#discussion_r740333130
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
##########
@@ -127,10 +127,16 @@
private final CompareType compareType;
private final boolean thinDriver;
private final String queryServerUrl;
+ private Properties connProperties = new Properties();
@VisibleForTesting
WorkloadExecutor workloadExecutor;
+ public Pherf(String[] args, Properties connProperties) throws Exception {
+ this(args);
+ this.connProperties = connProperties;
Review comment:
I think it makes sense to merge the two properties (connPropeties and
globalProperties) here. And use the merged property going forward?
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
##########
@@ -127,10 +127,16 @@
private final CompareType compareType;
private final boolean thinDriver;
private final String queryServerUrl;
+ private Properties connProperties = new Properties();
@VisibleForTesting
WorkloadExecutor workloadExecutor;
+ public Pherf(String[] args, Properties connProperties) throws Exception {
+ this(args);
+ this.connProperties = connProperties;
Review comment:
Can u rename properties field to globalProperties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
