virajjasani commented on a change in pull request #1363:
URL: https://github.com/apache/phoenix/pull/1363#discussion_r766535782
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java
##########
@@ -182,7 +182,7 @@ public Object getPTableValue(PTable table) {
},
- COLUMN_ENCODED_BYTES(PhoenixDatabaseMetaData.ENCODING_SCHEME,
COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, false, false, false) {
+ COLUMN_ENCODED_BYTES(PhoenixDatabaseMetaData.ENCODING_SCHEME,
COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, true, false, false) {
Review comment:
Nice one, curious any test was failing to validate table props without
this change earlier?
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/TransformIT.java
##########
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.end2end.index;
+
+import org.apache.phoenix.thirdparty.com.google.common.base.Strings;
+import org.apache.phoenix.end2end.ParallelStatsDisabledIT;
+import org.apache.phoenix.exception.SQLExceptionCode;
+import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData;
+import org.apache.phoenix.query.QueryServices;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.util.PropertiesUtil;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.Properties;
+
+import static
org.apache.phoenix.end2end.index.SingleCellIndexIT.assertMetadata;
Review comment:
Now that `assertMetadata` is moved to BaseTest, we can remove this to
avoid confusion (because SingleCellIndexIT doesn't have assertMetadata anymore
but this import still doesn't result into compilation failure because
`SingleCellIndexIT.assertMetadata` = `BaseTest.assertMetadata`)
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -5220,12 +5260,8 @@ private boolean evaluateStmtProperties(MetaProperties
metaProperties, MetaProper
throws SQLException {
boolean changingPhoenixTableProperty = false;
- if (metaProperties.getImmutableRowsProp() != null) {
+ if (metaProperties.getImmutableRowsProp() != null && table.getType()
!= INDEX) {
if (metaProperties.getImmutableRowsProp().booleanValue() !=
table.isImmutableRows()) {
- if (table.getImmutableStorageScheme() !=
ImmutableStorageScheme.ONE_CELL_PER_COLUMN) {
Review comment:
Got it, saw the ignored tests. Thanks
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -5384,7 +5435,7 @@ else if (metaProperties.getImmutableStorageSchemeProp()
!= table.getImmutableSto
return changingPhoenixTableProperty;
}
- private static class MetaProperties {
+ public static class MetaProperties {
Review comment:
Unless I missed something specific, looks like this change is not
required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
