gokceni commented on a change in pull request #1363:
URL: https://github.com/apache/phoenix/pull/1363#discussion_r767076397
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -5384,7 +5435,7 @@ else if (metaProperties.getImmutableStorageSchemeProp()
!= table.getImmutableSto
return changingPhoenixTableProperty;
}
- private static class MetaProperties {
+ public static class MetaProperties {
Review comment:
It is actually required. Transform.java refers this.
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java
##########
@@ -182,7 +182,7 @@ public Object getPTableValue(PTable table) {
},
- COLUMN_ENCODED_BYTES(PhoenixDatabaseMetaData.ENCODING_SCHEME,
COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, false, false, false) {
+ COLUMN_ENCODED_BYTES(PhoenixDatabaseMetaData.ENCODING_SCHEME,
COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, true, false, false) {
Review comment:
This property was used for immutable tables only I think. Now we changed
the behavior so that mutable indexes can benefit from this. It is not a
property reserved for immutable tables. And we didn't have any test to use this
property on mutable tables/indexes I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
