[ 
https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458779#comment-17458779
 ] 

ASF GitHub Bot commented on PHOENIX-6603:
-----------------------------------------

yanxinyi commented on a change in pull request #1363:
URL: https://github.com/apache/phoenix/pull/1363#discussion_r768181236



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -4354,6 +4360,18 @@ private PhoenixConnection upgradeSystemTask(
         return metaConnection;
     }
 
+    private PhoenixConnection upgradeSystemTransform(
+            PhoenixConnection metaConnection,
+            Map<String, String> systemTableToSnapshotMap)
+            throws SQLException {
+        try (Statement statement = metaConnection.createStatement()) {
+            statement.executeUpdate(getTransformDDL());
+        } catch (TableAlreadyExistsException ignored) {
+

Review comment:
       nit: better to add logging here so that we know the creation of the 
table is failed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Create SYSTEM.TRANSFORM table
> -----------------------------
>
>                 Key: PHOENIX-6603
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6603
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Gokcen Iskender
>            Priority: Major
>
> SYSTEM.TRANSFORM is a table for bookkeeping the transform process



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to