[
https://issues.apache.org/jira/browse/PHOENIX-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469519#comment-17469519
]
ASF GitHub Bot commented on PHOENIX-6620:
-----------------------------------------
stoty commented on pull request #1371:
URL: https://github.com/apache/phoenix/pull/1371#issuecomment-1006025907
The indextool fix is PHOENIX-6611 .
The fix for setting the verified flag for transactional tables in the normal
path was also included in that commit.
I am more worried abot the scenario where whe have a (transactional) table
with global indexes, and where the rows are in verified state, losing the
VERFIED status after transforming.
IndexToolIT.testSecondaryIndex() checks this here:
https://github.com/apache/phoenix/blob/01e1d2b4ef1758afef6b967f0959c8874e094596/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java#L332
The above test case checks for mutable, immutable, and transactional tables,
doing the same for Transforms may also be useful.
I can see you are adding the option to check all rows in this patch, but not
sure if we test that we don't break the already VERFIED rows' status during
transform, where we don't need to touch the index rows.
You may have added check for this for the other cases, I haven't read the
patch fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> TransformTool should fix the unverified rows and do validation
> --------------------------------------------------------------
>
> Key: PHOENIX-6620
> URL: https://issues.apache.org/jira/browse/PHOENIX-6620
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Gokcen Iskender
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
