[
https://issues.apache.org/jira/browse/PHOENIX-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486769#comment-17486769
]
ASF GitHub Bot commented on PHOENIX-6632:
-----------------------------------------
ashwinb1998 commented on a change in pull request #69:
URL: https://github.com/apache/phoenix-connectors/pull/69#discussion_r799089630
##########
File path:
phoenix-spark-base/src/it/scala/org/apache/phoenix/spark/PhoenixSparkIT.scala
##########
@@ -48,7 +48,7 @@ class PhoenixSparkIT extends AbstractPhoenixSparkIT {
.format("phoenix")
.options(Map("table" -> "TABLE3",
PhoenixDataSource.ZOOKEEPER_URL -> quorumAddress,
PhoenixDataSource.SKIP_NORMALIZING_IDENTIFIER -> "true"))
- .mode(SaveMode.Overwrite)
+ .mode(SaveMode.Append)
Review comment:
I believe there is an internal file source v2 API that uses Savemode for
writes, which is why we need to specify `mode(SaveMode.Append)`. SaveMode is
removed only from DataSourceV2 API, which means we won't be able to check from
the parameter if the given condition is Append or Overwrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Migrate connectors to Spark-3
> -----------------------------
>
> Key: PHOENIX-6632
> URL: https://issues.apache.org/jira/browse/PHOENIX-6632
> Project: Phoenix
> Issue Type: Improvement
> Components: spark-connector
> Affects Versions: connectors-6.0.0
> Reporter: Ashwin Balasubramani
> Priority: Major
>
> With Spark-3, the DatasourceV2 API has had major changes, where a new
> TableProvider Interface has been introduced. These new changes bring in more
> control to the data source developer and better integration with
> spark-optimizer.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
