[ 
https://issues.apache.org/jira/browse/PHOENIX-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510025#comment-17510025
 ] 

Lars Hofhansl commented on PHOENIX-6671:
----------------------------------------

Note that HBASE-26869 *does* fix the problem.

So now we have a choice to make:
 # State that only HBase 2.4.12 or later is supported (assuming the HBASE-26869 
lands in 2.4.12)
 # Put this patch in anyway - this might be the safest bet against other 
related issues.
 # Check the actual HBase version and create the right kind of connection 
depending on that.

I have no strong opinion one way of the other.

 

> Avoid ShortCirtuation Coprocessor Connection with HBase 2.x
> -----------------------------------------------------------
>
>                 Key: PHOENIX-6671
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6671
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Major
>             Fix For: 5.2.0, 5.1.3
>
>         Attachments: 6671-5.1.txt
>
>
> See PHOENIX-6501, PHOENIX-6458, and HBASE-26812.
> HBase's ShortCircuit Connection are fundamentally broken in HBase 2. We might 
> be able to fix it there, but with all the work the RPC handlers perform now 
> (closing scanning, resolving current user, etc), I doubt we'll get that 100% 
> right. HBase 3 has removed this functionality.
> Even with HBase 2, which does not have the async protobuf code, I could 
> hardly see any performance improvement from circumventing the RPC stack in 
> case the target of a Get or Scan is local. Even in the most ideal conditions 
> where everything is local, there was improvement outside of noise.
> I suggest we do not use ShortCircuited Connections in Phoenix 5+.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to