joshelser commented on code in PR #1425:
URL: https://github.com/apache/phoenix/pull/1425#discussion_r861395092
##########
phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionTable.java:
##########
@@ -372,4 +373,8 @@ public long getOperationTimeout(TimeUnit unit) {
throw new UnsupportedOperationException();
}
+ @Override
+ public RegionLocator getRegionLocator() throws IOException {
+ throw new UnsupportedOperationException();
Review Comment:
Phoenix doesn't end up calling this at all, I"m assuming?
##########
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java:
##########
@@ -89,7 +92,12 @@ public IndexHalfStoreFileReader(final FileSystem fs, final
Path p, final CacheCo
final byte[][] viewConstants, final RegionInfo regionInfo,
byte[] regionStartKeyInHFile, byte[] splitKey, boolean
primaryReplicaStoreFile,
AtomicInteger refCount, RegionInfo currentRegion) throws
IOException {
- super(fs, p, in, size, cacheConf, primaryReplicaStoreFile, refCount,
conf);
+ super(new ReaderContext(p, in, size, new HFileSystem(fs),
primaryReplicaStoreFile,
+ ReaderType.STREAM),
+ new HFileInfo(new ReaderContext(p, in, size, new HFileSystem(fs),
Review Comment:
Looking at HBase code, it looks like we shouldn't leak any copied filesystem
objects here.
We had a lot of perf issues with STREAM reads where they ended up being
slower than PREAD. It might be safer to start with PREAD and return to this
specifically when we're doing perf testing on this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
