[ 
https://issues.apache.org/jira/browse/PHOENIX-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529752#comment-17529752
 ] 

ASF GitHub Bot commented on PHOENIX-6696:
-----------------------------------------

stoty commented on code in PR #1427:
URL: https://github.com/apache/phoenix/pull/1427#discussion_r861448583


##########
phoenix-assembly/src/build/components/all-common-jars.xml:
##########
@@ -55,13 +47,5 @@
         <include>phoenix-pherf.jar</include>
       </includes>
     </fileSet>
-    <fileSet>
-      <directory>${project.basedir}/../phoenix-tools/target</directory>

Review Comment:
   We've dropped the phoenix-tools module/artifact some time ago, this is just 
an (unrelated) cleanup.





> Drop legacy phoenix-client jar
> ------------------------------
>
>                 Key: PHOENIX-6696
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6696
>             Project: Phoenix
>          Issue Type: Task
>          Components: core
>    Affects Versions: 5.2.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> phoenix-client JAR includes log4j1 and the slf4j log4j adaptor.
> For some releases, we've been providing phoenix-client-embedded, which omits 
> both the logging adaptor and backend, as well as sqlline, and is a superior 
> solution that doesn't force a logging solution on the user.
> As we're switching our default logging backend to slf4j2, users of the legacy 
> phoenix-client jar are likely to experience problems with the new logging 
> backend anyway, this a good time to drop the legacy phoenix-client jar, and 
> transitions its users to phoenix-client-embedded.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to